Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of additional characteristicNames that are the same constituent #9

Open
jbousquin opened this issue Sep 14, 2022 · 2 comments

Comments

@jbousquin
Copy link
Collaborator

Some variables have different names but represent the same constituent (e.g., "Total Phosphorus, mixed forms" and "Phosphorus"). Add characteristicNames that can be converted in the same way as an existing. May require:

  • re-structuring of domains.out_col_lookup()
  • filtering of results to limit qualifiers to those that are the same
  • further development of domains.accepted_methods()
@jbousquin
Copy link
Collaborator Author

TADA SubstituteDeprecatedChars leverages https://cdx.epa.gov/wqx/download/DomainValues/Characteristic.CSV, replace 'Name' with 'Comparable Name' col based on 'Domain Value Status' == 'Deprecated'. 'Group Name' may help further categorize Accepted names.

@jbousquin
Copy link
Collaborator Author

Link to TADA docs in docs for table for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant