Review RC [doc]: environment instructions for dev

[rcaneill]

Hi,
I am starting my in-depth review and will open issues with my questions / comments on the fly.

I believe that the package is missing some instructions for devs, like:

• how to install the dev environment
• how to run the tests

Here is what I did, I guess it is what should be done:

# install
pip install -e .
pip install -r requirements_dev.txt

# run the tests
pytest harmonize_wq

[rcaneill]

cf #64 The instructions should probably be:

# install
pip install -e .
pip install -r requirements.txt
pip install -r requirements_dev.txt

# run the tests
pytest harmonize_wq

[jbousquin]

Hi @rcaneill - This (pip install from requirements_dev) was added to the docs contributing page on the pyOpenSci-review branch. Once that is passing, merged and the docs built does it seem adequate to close this issue?

[rcaneill]

It's good to see it somewhere. However, I believe that "explicit is better than implicit", and so providing the exact commands to type should be done, as in #63 (comment)

I can open a PR for that, or let you do it (or if you disagree please tell me why)