Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider combining TADA_BigDataRetrieval and TADA_DataRetrieval into one function #425

Open
cristinamullin opened this issue Mar 19, 2024 · 1 comment
Labels
DataDiscoveryRetrieval.R Future Improvement Minimum viable function complete, issue includes potential future improvements Module 1

Comments

@cristinamullin
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When users query the WQP for data, it is not clear now if they should use TADA_BigDataRetrieval or TADA_DataRetrieval. If we can combine them in a smart way without impacting the efficiency/speed of TADA_DataRetrieval much, that would be ideal. There is already a lot of overlap (same code) across the two functions.

@cristinamullin cristinamullin added DataDiscoveryRetrieval.R Future Improvement Minimum viable function complete, issue includes potential future improvements Module 1 labels Mar 19, 2024
@cristinamullin
Copy link
Collaborator Author

Note: As of 3/20/24, the provider and project query inputs are not included in TADA_BigDataRetrieval. I don't believe the summary service query part of that function includes these filters which is why they were left out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataDiscoveryRetrieval.R Future Improvement Minimum viable function complete, issue includes potential future improvements Module 1
Projects
None yet
Development

No branches or pull requests

1 participant