Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcpl Data Processing Vignette Updates Accounting for Updates to tcplfit2 #227

Open
9 of 11 tasks
sedavid01 opened this issue Apr 9, 2024 · 1 comment · May be fixed by #240
Open
9 of 11 tasks

tcpl Data Processing Vignette Updates Accounting for Updates to tcplfit2 #227

sedavid01 opened this issue Apr 9, 2024 · 1 comment · May be fixed by #240
Assignees

Comments

@sedavid01
Copy link
Contributor

sedavid01 commented Apr 9, 2024

There is a need to update the vignettes for the ToxCast pipeline as outlined in: #210.

Here are the broad components for Data processing that may be relevant to update with the tcplfit2 package updates:

Data processing vignette updates to encompass:

  • New overwrite bidirectional mc and sc methods
  • Processing of all well types, even where NA/0 conc given conc fix to dev
  • BMD bounds
  • default error function
  • poly2 biphasic updates

Points identified as points that need to be updated, or consider updates:

  • Ensure Level 4 incorporates both bidirectional and biphasic aspects of modeling.
  • Table 7 update with poly2 biphasic
  • Figure 2 Update
  • Figure 3 may need updated as well
  • Table 9 may need updated
  • Figure 4 may need updated as well

Note, there may be other necessary updates -- or comparisons/explanations, particularly considering the poly2 biphasic updates. Please use this as a starting point and may be expanded as necessary for the relevant audience.

@gracezhihuizhao
Copy link

Figure 3, Table 9, and Figure 4 uses example data sets from mc_vignette. If we want to add the biphasic poly2 to the figures and table, we need to update the example data sets in mc_vignette with new poly2 results first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants