Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calc_mc_css with httkpop=FALSE, invitrouv=FALSE #17

Open
cm16120 opened this issue May 10, 2023 · 2 comments
Open

calc_mc_css with httkpop=FALSE, invitrouv=FALSE #17

cm16120 opened this issue May 10, 2023 · 2 comments
Assignees

Comments

@cm16120
Copy link

cm16120 commented May 10, 2023

Just reporting this in case the change in behaviour is not intended.

calc_mc_css(chem.cas = "xxxx", output.units = "uM", model = "3compartmentss", species = "Human", httkpop=FALSE, invitrouv=FALSE)
calc_analytic_css(chem.cas = "xxxx", output.units = "uM", model = "3compartmentss", species = "Human")

In HTTK 2.2.1, both of the above used adjusted Fup and Clint and gave the same outcome.

In HTTK 2.2.2, calc_mc_css appears to use unadjusted Fup and Clint and no longer gives the same outcome as calc_analytic_css (which continues to use adjusted Fup and Clint).

@jfwambaugh jfwambaugh self-assigned this Oct 8, 2023
@jfwambaugh
Copy link
Collaborator

Cool bug. cm16120 is right on the money... my variant of the example is:

a <- calc_mc_css(
  chem.cas = "80-05-7", 
  output.units = "uM", 
  model = "3compartmentss", 
  species = "Human", 
  httkpop=FALSE, 
  invitrouv=FALSE, 
  return.samples=TRUE)
b <- calc_analytic_css(
  chem.cas = "80-05-7", 
  output.units = "uM", 
  model = "3compartmentss", 
  species = "Human")
par <- parameterize_steadystate(chem.cas="80-05-7")
d <- calc_mc_css(
  parameters=par, 
  output.units = "uM", 
  model = "3compartmentss", 
  species = "Human", 
  httkpop=FALSE, 
  invitrouv=FALSE, 
  return.samples=TRUE)

the values in a differ from b and d. However, d has the expected behavior (that is, it is a bunch of replicates of b).

@jfwambaugh
Copy link
Collaborator

We partially addressed this in 2.3.0, but there is still an issue where create_mc_samples can't handle parameters=list (as in, the values you get from parameterize_steadystate). We're working on that now.

jfwambaugh pushed a commit that referenced this issue Feb 13, 2024
Merge in HTTK/httk-dev from HTTK-34 to patch/2.2.3 - changes relate to HTTK-35

* commit '7b5567159bb7bb3b5d6721b2b32a416053847e43':
  Updated grammar in model_solve.R times description on lines 56 and 57
  Updated description for 'times' argument on lines 56 and 57
jfwambaugh pushed a commit that referenced this issue Feb 13, 2024
Merge in HTTK/httk-dev from HTTK-34 to patch/2.2.3 - changes relate to HTTK-35

* commit '7b5567159bb7bb3b5d6721b2b32a416053847e43':
  Updated grammar in model_solve.R times description on lines 56 and 57
  Updated description for 'times' argument on lines 56 and 57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants