Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing/Documentation of cumDeaths28DaysByDeathDate #41

Open
timcoote opened this issue Jul 28, 2021 · 0 comments
Open

Typing/Documentation of cumDeaths28DaysByDeathDate #41

timcoote opened this issue Jul 28, 2021 · 0 comments

Comments

@timcoote
Copy link

The metric 'cumDeaths28DaysByDeathDate' reads like it is a monotonically increasing value. However, the last value can be NaN, which arguably ought not to be possible.

If it is intended to return NaNs in the dataset, then the documentation ought, I think, to point this out as pandas has some default handling of NaNs, which will create confusion (typically they are treated as 0 in some aggregations, thus making the data element non-monotonic).

Otherwise, if 'cumDeaths28DaysByDeathDate' is a calculated value (it is the sum of 'newDeaths28DaysByDeathDate'), then the returned value ought to be the same as the previous day's value, rather than NaN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant