Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why I should sorted in descending order of survival/censoring time. #2

Open
FiresWorker opened this issue Dec 9, 2019 · 4 comments

Comments

@FiresWorker
Copy link

Hi, I have a question, I don't know why I should requires that all subjects in the input batch must be sorted in descending order of survival/censoring time. This makes me very confused. Thank you very much for answering this question for me

@ghalib-bello
Copy link
Collaborator

Hi FiresWorker, please see explanation for this in code/trainDL.ipynb, under Section 4

@FiresWorker
Copy link
Author

Hi ghalib-bello, thank you so much for answering my question.
Section 4 said the sort is because of cumsum.
Actually I'm used to using pytorch, should I do the sort?

@ghalib-bello
Copy link
Collaborator

depends on how you choose to implement the partial likelihood function in pytorch

@FiresWorker
Copy link
Author

This is helpful for me to implement the survival loss in pytorch, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants