Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate fold_tr_newp issue / Flexibility of transform_group #141

Open
Tracked by #164
mmcleod89 opened this issue Jul 6, 2023 · 0 comments
Open
Tracked by #164

Investigate fold_tr_newp issue / Flexibility of transform_group #141

mmcleod89 opened this issue Jul 6, 2023 · 0 comments
Projects

Comments

@mmcleod89
Copy link
Collaborator

In pregnancy module we need to take fold_tr_newp from hiv_status.

  • This gets set in an internal self.fold_tr_newp in pregnancy as well in order to get around passing it into the transform_group method which only applies to dataframe columns
  • Not sure if fold_tr_newp is const or not, but if it isn't then these have the potential to be out of sync --> better to define it in just one place
  • We can get around this using bind/lambda but this may be a bit clunky
  • We may want to alter transform_group (ideally in a backwards compatible way i.e. any additional variables having a default such as None
  • We also want to rename fold_tr_newp to e.g. newp_transmission_factor or similar
@mmcleod89 mmcleod89 added this to To do in HIVpy via automation Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
HIVpy
To do
Development

No branches or pull requests

1 participant