-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HealthSystemChangeParameters
event has no effect when asked to update BedDays
policy
#1346
Comments
Ping @tbhallett |
Thanks for spotting this, @willGraham01 The intended behaviour is that, mid-way through a simulation, the total numbers of bed available can be changed (either up or down). So, I agree with you that this is a bug. |
What should the intended behaviour be if the number of beds is reduced below what's currently occupied? Say I have 5 beds occupied at a facility, then the availability changes to none - do all the patients have to be kicked out immediately or do we let them stay but accept no others? |
We let them stay. They will eventually be discharged and then we accept no others.
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Will Graham ***@***.***>
Sent: Tuesday, May 14, 2024 2:47:55 PM
To: UCL/TLOmodel ***@***.***>
Cc: Hallett, Timothy B ***@***.***>; Mention ***@***.***>
Subject: Re: [UCL/TLOmodel] `HealthSystemChangeParameters` event has no effect when asked to update `BedDays` policy (Issue #1346)
This email from ***@***.*** originates from outside Imperial. Do not click on links and attachments unless you recognise the sender. If you trust the sender, add them to your safe senders list<https://spam.ic.ac.uk/SpamConsole/Senders.aspx> to disable email stamping for this address.
What should the intended behaviour be if the number of beds is reduced below what's currently occupied?
Say I have 5 beds occupied at a facility, then the availability changes to none - do all the patients have to be kicked out immediately or do we let them stay but accept no others?
—
Reply to this email directly, view it on GitHub<#1346 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJRDOFC2PISJGRYOCNEOZ4TZCIIYXAVCNFSM6AAAAABHV5XLJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQGI4TENRVGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
When the
HealthSystemChangeParameters
event is called/scheduled to update the behaviour of the bed-days allocations, it does not change the behaviour of the bed-days allocations in theHealthSystem
.The
HealthSystemChangeParameters
event which changes the availability of bed days currently changes theBedDays.availability
property when it runs:BedDays.availability
value is only used by theBedDays
class inset_scaled_capacity
set_scaled_capacity
itself is only used in theinitialise_beddays_tracker
method.initialise_beddays_tracker
is only called once in the initial setup of the simulation (specifically in theinitialise_simulation
step for each module).As such, changing the
BedDays.availability
property when an event fires after the simulation begins has no effect.If we really only need to set the properties of the BedDays tracker before the simulation, we don't need an event to handle changing them. Otherwise, presumably the correct action that should be taken is that the
availability
property should be updated, and the internal trackers for maximum capacities should also be updated? This might lead to issues with the current and forecast allocations though (since EG setting the availability to 0 will mean that any currently scheduled occupancies have to end).If anyone knows what the intended behaviour is meant to be (or whether we need this feature at all), advice would be appreciated!
The text was updated successfully, but these errors were encountered: