Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HealthSystemChangeParameters event has no effect when asked to update BedDays policy #1346

Open
willGraham01 opened this issue May 14, 2024 · 4 comments · May be fixed by #1352
Open

HealthSystemChangeParameters event has no effect when asked to update BedDays policy #1346

willGraham01 opened this issue May 14, 2024 · 4 comments · May be fixed by #1352
Labels
bug Something isn't working

Comments

@willGraham01
Copy link
Collaborator

willGraham01 commented May 14, 2024

When the HealthSystemChangeParameters event is called/scheduled to update the behaviour of the bed-days allocations, it does not change the behaviour of the bed-days allocations in the HealthSystem.

The HealthSystemChangeParameters event which changes the availability of bed days currently changes the BedDays.availability property when it runs:

  • The BedDays.availability value is only used by the BedDays class in set_scaled_capacity
  • set_scaled_capacity itself is only used in the initialise_beddays_tracker method.
  • initialise_beddays_tracker is only called once in the initial setup of the simulation (specifically in the initialise_simulation step for each module).

As such, changing the BedDays.availability property when an event fires after the simulation begins has no effect.

If we really only need to set the properties of the BedDays tracker before the simulation, we don't need an event to handle changing them. Otherwise, presumably the correct action that should be taken is that the availability property should be updated, and the internal trackers for maximum capacities should also be updated? This might lead to issues with the current and forecast allocations though (since EG setting the availability to 0 will mean that any currently scheduled occupancies have to end).

If anyone knows what the intended behaviour is meant to be (or whether we need this feature at all), advice would be appreciated!

@willGraham01 willGraham01 added the bug Something isn't working label May 14, 2024
@tamuri
Copy link
Collaborator

tamuri commented May 14, 2024

Ping @tbhallett

@tbhallett
Copy link
Collaborator

Thanks for spotting this, @willGraham01

The intended behaviour is that, mid-way through a simulation, the total numbers of bed available can be changed (either up or down).

So, I agree with you that this is a bug.

@willGraham01
Copy link
Collaborator Author

What should the intended behaviour be if the number of beds is reduced below what's currently occupied?

Say I have 5 beds occupied at a facility, then the availability changes to none - do all the patients have to be kicked out immediately or do we let them stay but accept no others?

@tbhallett
Copy link
Collaborator

tbhallett commented May 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants