Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach R^2 instead of RMSPE? #131

Open
trevorcampbell opened this issue Jan 12, 2023 · 3 comments
Open

Teach R^2 instead of RMSPE? #131

trevorcampbell opened this issue Jan 12, 2023 · 3 comments
Labels
enhancement New feature or request low-priority needs-investigation Further information is requested

Comments

@trevorcampbell
Copy link
Contributor

In scikit-learn, all the regressors use $R^2$ instead of RMSPE for evaluation. It makes using RMSPE kind of a pain -- we have to jump through hoops.

But it would be a pretty major change, so I'm just opening this for discussion once the textbook has stabilized. Certainly not a v1 thing to do.

@trevorcampbell trevorcampbell added enhancement New feature or request needs-investigation Further information is requested low-priority labels Jan 12, 2023
@trevorcampbell trevorcampbell changed the title Teach $R^2$ instead of RMSPE? Teach R^2 instead of RMSPE? Jan 12, 2023
@joelostblom
Copy link
Collaborator

There is some discussion on this here by Tiff and Mathias https://github.ubc.ca/UBC-DSCI/dsci-100-instructor/issues/43. I personally find the name RMSPE a bit confusing since the formula is the same as RMSE and it is just the data that it is applied to that is different.

@joelostblom
Copy link
Collaborator

Just a note that after teaching in 2023 fall I came across this again and find it hard to justify to students (and myself) why we make a distinction in the name between RMSPE and RMSE whereas we don't do that for any other metric we use (none of accuracy, precision, recall don't change names when applied to test data) and if students look up other regression metrics to use with sklearn in the docs they will also not come across any difference in naming convention between the same metric applied to different data sets.

@trevorcampbell
Copy link
Contributor Author

trevorcampbell commented Nov 7, 2023

I think the RMSPE vs RMSE and R^2 vs RMS(P)E are different issues. Probably worth keeping the discussion here for now I guess because they're related, but might be worth spinning that into a separate issue at some point if it gets too disjoint.

On the RMSE vs RMSPE issue: I agree with you, but if we want to change that we'd need to discuss with the teaching team (and course design team) to make sure everyone is happy with it. It's also a fairly minor change compared to other stuff we're working on, so low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority needs-investigation Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants