Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.15.1 needs TypeScript 3.7.x and breaks with Protractor code #1134

Closed
1 task done
woppa684 opened this issue Nov 14, 2019 · 3 comments
Closed
1 task done

0.15.1 needs TypeScript 3.7.x and breaks with Protractor code #1134

woppa684 opened this issue Nov 14, 2019 · 3 comments
Labels
bug Functionality does not match expectation wontfix Declining to implement

Comments

@woppa684
Copy link

I'm mainly creating this bug because it cost me a lot of time to find the culprit... I have in my package.json

"typedoc": "^0.15.0"

so it automatically installed 0.15.1, which caused errors like

[15:56:03] node_modules/protractor/built/index.d.ts(4)
 Import declaration conflicts with local declaration of 'PluginConfig'.
[15:56:03] node_modules/protractor/built/index.d.ts(4)
 Import declaration conflicts with local declaration of 'ProtractorPlugin'.

Expected Behavior

A patch release (going from 0.15.0 to 0.15.1) doesn't break existing code.

Actual Behavior

The (automatic) update to version 0.15.1 requires TypeScript 3.7.x which breaks typedoc'ing code that uses Protractor because of this bug angular/protractor#5348.

Steps to reproduce the bug

TypeDoc a project which depends on Protractor 5.4.2.

Environment

  • TypeDoc version: 0.15.1
  • Node version: 10.15.3
  • OS: Windows 10
@woppa684 woppa684 added the bug Functionality does not match expectation label Nov 14, 2019
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 14, 2019

Ouch, sorry about that. I released as 0.15.1 since I've been adding issues to the 0.16 milestone that weren't ready yet. Clearly I should have renamed that to 0.17 and released 0.15.1 as 0.16. I'll be sure to do this for future releases that upgrade the TS version.

@ravi005e
Copy link

ravi005e commented Dec 3, 2019

issue still remains

@Gerrit0 Gerrit0 added the wontfix Declining to implement label Dec 3, 2019
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Dec 3, 2019

If you're running into this I recommend changing your targeted version to "0.15.0" so that npm doesn't automatically upgrade. I'm not going to overwrite versions to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation wontfix Declining to implement
Projects
None yet
Development

No branches or pull requests

3 participants