Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-9985] Add HTTP proxy protocol handling #5463

Open
ldmonster opened this issue Aug 24, 2023 · 6 comments
Open

[TT-9985] Add HTTP proxy protocol handling #5463

ldmonster opened this issue Aug 24, 2023 · 6 comments

Comments

@ldmonster
Copy link

ldmonster commented Aug 24, 2023

Is your feature request related to a problem? Please describe.
We already have an TCP handling of ha-proxy-protocol, but still not support HTTP/HTTPS.
In our case, we want to parse ha-proxy protocol in tyk, not any service before or after.

Describe the solution you'd like
We already have a solution for ourselves, but we want to tyk use it, because we want to use new stable versions with this feature.
We add new GatewayConfig toggle, to enable all ha-proxy-protocol handling on HTTP/HTTPS/h2c.

{
  "enable_proxy_protocol_http": true
}

Describe alternatives you've considered
We already trying to use nginx before or after, but it looks like overhead, when we can do it on tyk

Additional context
This feature already requested before
#2300 (comment)
Our branch
https://github.com/ldmonster/tyk/tree/feature/add-proxy-protocol

@andyo-tyk
Copy link
Contributor

Hi @ldmonster,

Thanks for getting in touch with this. I've taken a look at the original ticket and can see that it was auto-closed by a bot that we were running a while back, because the bot detected it as stale.

We're very open to community PRs, which are a lot easier to inspect than your fork of the Tyk codebase. Would you consider raising a PR, then we'll be able to take a look more promptly?

Thank you for supporting Tyk!

@andyo-tyk andyo-tyk changed the title Add HTTP proxy protocol handling [TT-9985] Add HTTP proxy protocol handling Oct 17, 2023
@ArcRiiad
Copy link

Hey folks! any update on supporting Proxy Protocol?

@ldmonster
Copy link
Author

Hey folks! any update on supporting Proxy Protocol?

We have PR

#5464

@OlegPS
Copy link

OlegPS commented May 6, 2024

Hi @andyo-tyk , could you please take a look?

@ldmonster
Copy link
Author

@andyo-tyk PTAL

@andyo-tyk
Copy link
Contributor

Hi @OlegPS @ldmonster,

Sorry for the slow reply on this, not sure how I missed it. We'll take a look at this, please bear with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants