Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of minor points about combat information #1967

Open
Sanglorian opened this issue Jun 18, 2023 · 1 comment
Open

Couple of minor points about combat information #1967

Sanglorian opened this issue Jun 18, 2023 · 1 comment
Labels
Combat Discussion Free form converation on a topic

Comments

@Sanglorian
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Just a few minor issues relating to how combat information is displayed:

  • The message about XP gained should come after the message about the monster being knocked out.
  • When a monster avoids capture, is it possible to not go on to the next stage of the battle until the player has clicked Enter/Shift? At the moment, the capture fails and the monster that's the target of the capture immediately attacks, making it a little hard to follow what's happening.
  • It's fantastic that the Tuxepedia page about the captured monster pops up after the capture occurs - it really adds something. Is it possible to make Enter/Shift make the page disappear, not just escape?

Thanks for considering these!

Grimmys added a commit to Grimmys/Tuxemon that referenced this issue Aug 17, 2023
@Grimmys
Copy link
Contributor

Grimmys commented Aug 17, 2023

It's fantastic that the Tuxepedia page about the captured monster pops up after the capture occurs - it really adds something. Is it possible to make Enter/Shift make the page disappear, not just escape?

Looks like pressing "Shift" is already making the page disappear.
Also, these controls look the same in any other place a Tuxepedia page is opening.
Meaning that adding "Enter" as an alternative key for closing the page after the capture, would also likely add it for the case where the page is shown directly from the Tuxepedia entry menu, or for example when the player is checking the Tuxemons that are in the bins.

I have no issue with this though, I think it could be fine to have the "Enter" key to close the page in every cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Combat Discussion Free form converation on a topic
Projects
None yet
Development

No branches or pull requests

3 participants