Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Probably a deliberate design]The comment preview is white in dark mode #933

Open
MFn233 opened this issue May 11, 2024 · 2 comments
Open

Comments

@MFn233
Copy link

MFn233 commented May 11, 2024

The comment preview is white in light mode:
image

However, in dark mode, it's also white:
image

I don't know if this was deliberately designed...
If so, please let me know
Otherwise, fix it please.

I made a user style to fix this.

/*--color-scheme: dark; is dark mode, but idk how to detect it.*/
.sa-comment-preview-inner {
    color: rgb(255, 255, 255);
    background-color: rgb(0 0 0 / 90%);
    filter: drop-shadow(0px 5px 5px rgb(255 255 255 / 20%));
}
@supports (backdrop-filter: blur(16px)) {
    .sa-comment-preview-inner {
        background-color: rgb(0 0 0 / 75%);
        backdrop-filter: blur(16px);
    }
}

...and it worked well on turbowarp.org/editor
image

I wanted to send a pull request, but i have no idea where to put the code...(and also i don't exactly know how to send a pull request)
and I am somehow weak in english, perhaps there may be content that you can't understand well, but I don't think there will be too much reading barriers

@GarboMuffin GarboMuffin transferred this issue from TurboWarp/desktop May 11, 2024
@GarboMuffin
Copy link
Member

normally addon stuff goes to Scratch Addons to fix but our dark mode works very differently from theirs so this is our problem

@MFn233
Copy link
Author

MFn233 commented May 12, 2024

normally addon stuff goes to Scratch Addons to fix but our dark mode works very differently from theirs so this is our problem

thanks for telling me this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants