Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TurboWarp not connecting to cloud_host URL parameter #645

Open
MikeDev101 opened this issue Nov 11, 2022 · 5 comments · May be fixed by #655
Open

TurboWarp not connecting to cloud_host URL parameter #645

MikeDev101 opened this issue Nov 11, 2022 · 5 comments · May be fixed by #655

Comments

@MikeDev101
Copy link

Expected Behavior

Opening a project with cloud variables enabled and the cloud_host parameter set should connect to that cloud variable server and start syncing cloud variables.

I'm testing older projects of mine that use Cloud Variables.

I'm also testing my Python-based reimplementation of the Cloud Variable protocol (source).

My Cloud variable host is wss://cl4-test.meower.org/, which autodetects the protocol whenever the handshake method is made.

Actual Behavior

TurboWarp doesn't attempt to connect to the cloud variable host.

My cloud variable host is working, as it connects and syncs fine using Sheeptester's mod. I open the project editor and use the "Set test to #" block and it synchronizes the variable state just fine.

However, when I test the same project using TurboWarp, it never connects to the server.

Steps to Reproduce

Using this test project,

  1. Load TurboWarp with cloud_host url parameter set to wss://cl4-test.meower.org/
  2. File > Load from your computer > test.sb3
  3. Check inspect console, no attempted connections to wss://cl4-test.meower.org/
  4. Toggle "Enable/Disable Cloud Variables"
  5. Move the Test cloud variable slider - Still no response

Operating System and Browser

Windows 10.0.19044, Google Chrome 107.0.5304.106

Note

This is more of a suggestion, but I think TurboWarp should allow editing projects with Cloud Variables enabled if it detects a custom cloud variable host.
@GarboMuffin
Copy link
Member

Issue is that projects loaded from files can't use cloud variables

@GarboMuffin
Copy link
Member

GarboMuffin commented Nov 13, 2022 •
edited

Here's what I'm considering:

  • Projects from files will be able to use cloud variables (project ID generated by project title)
  • You will be able to use cloud variables in any project in the editor, but you will be put into a different "room" from people who haven't opened the editor

Would that work for you?

@MikeDev101
Copy link
Author

Here's what I'm considering:

  • Projects from files will be able to use cloud variables (project ID generated by project title)
  • You will be able to use cloud variables in any project in the editor, but you will be put into a different "room" from people who haven't opened the editor

Would that work for you?

That sounds fine. I think it would actually be beneficial to separate users who have/haven't opened the editor.

GarboMuffin added a commit that referenced this issue Nov 20, 2022
@GarboMuffin
Allow using cloud variables in projects loaded from files and in the …
f6464d2 
…editor

For projects from files, we generate a room ID from the title (similar
to the packager). In the editor, we prefix the room ID so that cloud
variables still work but remain separate from variables outside of the
editor.
Closes #645
GarboMuffin added a commit that referenced this issue Nov 20, 2022
@GarboMuffin
Allow using cloud variables in projects loaded from files and in the …
86204cc 
…editor

For projects from files, we generate a room ID from the title (similar
to the packager). In the editor, we prefix the room ID so that cloud
variables still work but remain separate from variables outside of the
editor.
Closes #645
@GarboMuffin GarboMuffin linked a pull request Nov 20, 2022 that will close this issue
Open
@GarboMuffin
Copy link
Member

Sorry for delay on this.

Please test the experiment: https://experiments.turbowarp.org/cloud-variables-anywhere/

@MikeDev101
Copy link
Author

Works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow using cloud variables for projects uploaded from files and in the editor TurboWarp/scratch-gui
2 participants
@MikeDev101 @GarboMuffin