Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorPageApplicationWrapper without TraceErrorsMiddleware will mute tracebacks #119

Open
kiilerix opened this issue Apr 22, 2020 · 0 comments

Comments

@kiilerix
Copy link

ErrorPageApplicationWrapper will (if enabled) catch application errors and (if handle_exceptions (which is default)) store them in backlash.exc_environ and backlash.exc_info where backlash TraceErrorsMiddleware can pick it up. It will catch and store no matter if backlash.TraceErrorsMiddleware actuallly is enabled. Disabling backlash with trace_errors.enable (which users might want for other reasons) will thus effectively hide application errors. That dependency will confusingly hide errors when they happen, and doesn't seem necessary.

I suggest to effectively let errorpage.handle_exceptions default to false if not using TraceErrorsMiddleware.

(In some ways it seems like it would be better have these two middlewares come in the opposite order.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant