Add x86 to abiFilters #2480
Closed
Add x86 to abiFilters #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siepra
reviewed
Apr 25, 2024
| @@ -198,7 +198,7 @@ android { | |||
| testBuildType System.getProperty('testBuildType', 'debug') | |||
| testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner' | |||
| ndk { | |||
| abiFilters "arm64-v8a" | |||
| abiFilters "arm64-v8a", "x86_64", "x86" | |||
There was a problem hiding this comment.
We intentionally target only arm64 devices (there're only 33 x86 and x86_64 devices)
There was a problem hiding this comment.
I don't think it's a good idea to bring it back because we lack x86 binaries for Tor, NodeJS and classic-level anyways
There was a problem hiding this comment.
There was a problem hiding this comment.
Okay, yes you're right. I misunderstood what the abi is, and misattributed what made my build start succeeding. I'll close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: