-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Trial of Champion] Event bugged. [$50 bounty] #383
Comments
Worse yet. If you go into the instance and mount an Argent Worg and exit the instance mounted it dumps you into the frozen sea in the Borean Tundra with no hope of making it to shore in time (fatigue death). It may do that even if you dismount, not willing to test it any more. 2012-06-14 20:41:28 -0230 (8962b88+) (Win64, Release) |
Random 3 of those 5 mounts are summoned inside the instance and start attacking to players. |
I know, but the mobs of those ids are show on outdoor pics :) |
You can apply the patch and test yourself :) I just copied the id's from header file trial_of_the_champion.h. P.S: Is there any web based IRC? The page irc.rizon.net cannot load. |
Yeah, but that don't means it's correct XD |
|
From @toxicburnz in #10267:
|
I have been trying to apply your fix but I can't get it to apply. Does this still work ? Should I copy and paste by hand ? |
"Trial of the Champion Might it just be in relation with issue #10383 , and that the 3 triplets ads might have no horseman on them because they have been dropped of while getting inside? In the following act (The Argent Crusade Represenatives) , where you have to fight triplets of ads composed by priests and paladins don´t attack the party, even if you pull one of them. The path about "the return of the black knight" is working so far. I also noticed that:
|
Still pretty broken on latest core: Current core: TrinityCore rev. c0224dd 2014-02-01 13:27:16 +0100 (HEAD branch) (Unix, Release) |
If anyone wanna fix this instance we can supply sniffs for it, jump into irc. |
wrong GUID taken ?? at bool GrandChampionsOutVehicle(Creature* me).... Creature* pGrandChampion1 = Unit::GetCreature(me, instance->GetData64(DATA_GRAND_CHAMPION_1)); if (pGrandChampion1 && pGrandChampion2 && pGrandChampion3) |
This dungeon is still broken. |
What is irc and where do I find the fix for this dungeon? |
He is looking for the fix, no to help to fix, so pointeless. |
@Aokromes I'd like to give it a try. It would be superb, if you could provide me the sniffs. |
Added an extra $20 on this in hopes to give someone more incentive to work on it. |
probably fixed by this repo https://github.com/TrinityCore/TrinityCore/commits/3.3.5-trial_of_the_champion |
@ceresia & @bumbummen99 : please post some feedback as to which extent this issue is solved. |
Sorry for not taking part in conversation that long. Could you please upload some media or a list of issues left to fix? I currently have no time at as i am in the middle of my final exam (software engineering). Otherwise i'd follow @ceresia decision and your view of the state. I have donated to this issue as i wanted it to vanish (it has been around since 2011). I am also satisfied if there is someone actively working on and improving it. To me it is fixed when it resembels the blizz experience as much as there is information to verify it including infight (spells, movement), phases, emotes/speech and so on. I could offer to take some of my time to create some german translations if there are missing ones. |
Very well. This issue will stay open until someone posts a confirmation that the instance works as expected and is more or less stable. |
Hey guys - i have took the relevant code from the 3.3.5-trial_of_the_champion branch and adapted it to compile with 3.3.5 revision 826b3cf (from today). I don't know if this is correct to test it this way but at least its compiling and I am testing this ingame at the moment. so far it looks promising. Update: https://ibb.co/gQp3J7 i will make a video and detailed explanation for the issues that i may encounter probably later today. |
That ibb.co image server does not seem to be very stable (at least not for me). I saw 1 maybe 2 images, then they turned blank (image disappeared). Most of the other pages timed out as if the server was down. https://imgur.com/ would be a better choice if those images are meant to be useful in any way. Then again, I don't see the point of those images unless there is readable source code along with the images. Maybe you could link your local source branch so we can see what you are talking about. The main point about TrinityCore is to learn more coding and to follow the existing TC code style standards. I don't see any big problems in implementing a working Trial of the Champions instance, as long as it can be checked by TC members experienced in coding for the TC source to get useful feedback on if the source code changes are acceptable or not. |
Hey @tkrokli Thanks for reply. Since on your last message you said that the issue will stay opened until some people post confirmation of this event working and more or less stable, i just wanted to help by testing this out. i actually changed only like 2 or 3 lines to make it compile with one of the latest trinity core rev. I thought that pics (or video) and list of issues (if any) would be a good way to help this. If its not a good way, i will be happy if you can address me to the right place so i can learn how to properly check and/or confirm other people works and not wasting other people time... |
Linking a working branch from your own repository would be a good start. I know at least @Jildor and a couple of others would be interested. Maybe even @Keader would like to have a look. Then again, if the changes you made are so minor that it is mostly the same as the content in https://github.com/TrinityCore/TrinityCore/tree/3.3.5-trial_of_the_champion , I suggest making a PR to the |
@tkrokli Hey thanks again for reply. I tried to merge it with the 3.3.5-trial_of_the_champion but looks like i dont know how to do it properly... its trying to merge all the differences between 3.3.5 and 3.3.5-trial_of_the _champion probably because i used 3.3.5 branch to do this. Maybe i should try a PR to 3.3.5 instead ? there i have no issues... |
Looks good so far. Some time in the future, when your PR becomes part of the |
Can we put a bounty on this issue? Maybe collect 200-300$ bounty funds , and someone will be motivated enough to finalize the scripting of this instance. |
@RR2739-VCN : Bountysource page for this issue ticket: |
@illfated Thank you for the link i see the bounty on it. |
If anyone have plans to takeover #21427 plz split it on multiple PRs to make it faster to review and merge. |
Hello. does anybody know why the TOC is closed? We are receiving a message "This instance is closed". |
@noszone : The simple answer is: Because it does not work well enough to be used (all events must work for the instance to be completable). |
it does not work at all. |
@ceresia @bumbummen99 make sure to redeploy or withdraw your bounty. New TOS of bountysource will "steal" your money if you dont do so. |
-Start the event, first encounter shows up , but they won't change their flags, they just stay there unatackable.If i change their flags , they will start and attack (low damage per hit).
Moving to second phase of the first encounter , the three bosses act normal , you kill them but the chest doesn't spawn(not even in other phases).
-After this the event starter gets his npcflag set to 0. I will change his npcflag to 1 , i start the next encounter , kill the boss ,same problem the chest isn't there.
-At the final boss , the event starter acts the same , resets his npcflag to 0.Set npcflag to 1 start the event , The Black Knight acts good scripted , has the loot set.
There is a $15 open bounty on this issue. Add to the bounty at Bountysource.
The text was updated successfully, but these errors were encountered: