-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brewfest] Down with the Dark Iron (full event) [$10 Bounty] #3620
Comments
Has anyone tested this? |
i am currently testing with someone else, but need some changes |
I tested @Discover's code and it is causing a critical error on the client due to stack overflow. |
the core part is changed as well but not from me, need to ask for permission to post, since its a private repo |
the client still crashes + spell_gen_dark_iron_knockback_test, i cant find the code for this part and yet its still in the sqls |
Is it crashing for you @LuckerNr1? If not the problem might be within the c++ itself, although I highly doubt it. |
got the permission for posting the c++ part notes:
|
Any news about this? |
@LuckerNr1: who gave you permission? And since when do you even need permission to share code that was originally written for opensource? |
|
LuckerNr1 patch need update this |
Is there anyway to get the achievement ? I could not add the achievement for this. |
achievement is for complete quest, this script is for mechanic for get this quest. |
@milotic |
Can some good soul update the c++ and sql files for latest trinity 4.3.4? |
The client still crashes with Stack Overflow error in last tc release. |
Even if "last tc release" is accurate to you right now, that statement loses its meaning within a few days, maybe just some hours. Please add the core hash and TDB version to your post. |
Tranks for your reply and sorry about this one. Every day I download the last changes from git and update my TDB, I don't know how can I check the hash of my version. |
@elperro22 the easiest way is by opening the Server.log file and checking the 4th line - the string right after "TrinityCore rev. " or you could copy/paste the whole line. |
Or simply look the last row after server startup. |
Thanks!! Mmmm it's strange, in the two lines it's this one "TrinityCore rev. unknown 1970-01-01 00:00:00 +0000 (Archived branch) (Win32, Release) (worldserver-daemon)" |
Thank you Aokromes. 961aaf5 is the version. |
The C++ code is the same so I edited SQL code to this one http://pastebin.com/ZecUfAvf |
Now I have b74ef3f and TDB 56 and the issue persist. |
Anyone giving love to this issue :) |
Maybe a status update would be nice, what is working and what is not? Are some parts already implemented? |
Sorry I have no clue. It's been 4 years since I did this, code style is horrible too. |
Anyone can takeover this fix and make a PR with the needed parts? |
Any News ? |
Holy shit, this is already 6 years ago?! |
I might check into this again too. |
Did anyone test it? |
@peycho make sure to redeploy or withdraw your bounty. New TOS of bountysource will "steal" your money if you dont do so. |
I'm not sure how to do that... |
@peycho you can write an email at their support. |
My gosh. I read the e-mail now. Thanks @funjoker |
I wrote them:
Today's e-mail from bountysource:
I guess they came to conclusion that this is actually really wrong. |
Came here to log for Brewfest 2021 but found this post |
It's a real shame that all the standard events don't work properly. I used the search a bit and see that the events are all neglected, which I think is a real shame :( |
You will have to replace the RAND define in snake script in npcs_special to RAND_SNAKES since it's also a function.
I'd like to thank Josh, Shauren and some other guys who helped me with this.
C++
https://gist.github.com/1305188
SQL
https://gist.github.com/1305191
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: