-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sindragosa's Ice Tomb remains on player and won't take damage after relogging back #25718
Comments
Just want to add that once players have Ice Tomb stays on them, they don't get hurt from now on, meaning that you can go Lich King, or any other bosses without getting damage. |
Sounds like an unexpected exploit to me, if the ice tomb stays with you forever as a permanent "bubble". |
Seems like a linked aura is not removed correctly. Will check tomorrow |
this is the aura SPELL_ICE_TOMB_UNTARGETABLE |
possible fix: diff --git a/src/server/game/Spells/Auras/SpellAuras.cpp b/src/server/game/Spells/Auras/SpellAuras.cpp
index fc1147c5e5..ac8c05fd7f 100644
--- a/src/server/game/Spells/Auras/SpellAuras.cpp
+++ b/src/server/game/Spells/Auras/SpellAuras.cpp
@@ -1165,6 +1165,7 @@ bool Aura::CanBeSaved() const
case 37025: // Water, Coilfang Raid
case 36444: // Water, Lake Wintergrasp
case 28801: // Slime, Naxxramas
+ case 69700: // Ice Tomb
return false;
}
|
Looks interesting. Waiting for feedback from the TC coders on that suggestion. |
@Keader since you have proficiency on this, could you debug the aura removal on player logout? |
This happens after this commit: 54e8418
spell 70157 (spell_sindragosa_ice_tomb_trap) has aura area target, so when player logout, loses aura, I think player should keep aura when logout, so when player login again, would keep 70157 (stun and resummon ice tomb npc) and 69700 (ice tomb unattackable effect) Also that commit causes problems with raid buffs, by example if you buff raid and/or pets, when you logout player or by example you have a pet and you mount and dismount, pet or logout player loses raid buffs because can't be saved. in my opinion that @ariel- commit is wrong, I don't know if this area aura check should be needed for avoid crashes or can be removed. |
Description:
Sindragosa in Icecrown Citadel, once it casts Ice Tomb on a player, logout or disconnect the player and let the team wipe to stop the engagement, log the player back and Ice Tomb stays on player. At this point, player will not affect any damage from Sindragosa and this player can heal other players.
Expected behaviour:
Ice Tomb aura gets clear out from player when logged off/disconnected
Steps to reproduce the problem:
Video explains better: https://mega.nz/file/8WAkhb5D#LQ8P7spfwswx3YZv2EOA2uYNqKRrgiBmBcolQ7osWOM
Jump to 0:55 if you can't wait the video
Branch(es):
3.3.5
TC rev. hash/commit:
commit# cc98f68
Operating system:
debian 10.4
The text was updated successfully, but these errors were encountered: