Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 591 move tresobject tres to a weakmap #593

Closed
wants to merge 22 commits into from

Conversation

alvarosabu
Copy link
Member

Closes #591

alvarosabu and others added 21 commits December 22, 2023 16:31
* feat: vue chrome devtools

* feat: editable scenes from devtools

* chore(lint): fix lint errors

* feat: highlight material

* chore(lint): fix
* feat: conditional rendering

* chore: remove subscribe system

* feat: on-demand automatic invalidation with prop changes

* feat: invalidate once first when is `renderMode !== 'always'`

* docs: performance page, on-demand rendering

* chore: fix windowsize issue

* chore(lint): fix maximum line length issues

* feat: invalidate on-demand on window resize

* feat: add advance method for manual mode

* feat: fix manual first render with advance

* docs: performance manual mode

* docs: add badge with version

* chore: correct typos and PR suggestions

* chore: tell dont ask fix

* feat: render state instead of internal
* feat: remove annoying defautl camera warning

* chore: remove logWarning
* feat: set ACESFilmicToneMapping as default toneMapping

* chore: usage of nullish coealescing operator instead of ternaries
…erdata (#522)

* feat: conditional rendering

* chore: remove subscribe system

* feat: on-demand automatic invalidation with prop changes

* feat: invalidate once first when is `renderMode !== 'always'`

* docs: performance page, on-demand rendering

* chore: fix windowsize issue

* chore(lint): fix maximum line length issues

* feat: invalidate on-demand on window resize

* feat: add advance method for manual mode

* feat: fix manual first render with advance

* docs: performance manual mode

* docs: add badge with version

* chore: correct typos and PR suggestions

* chore: tell dont ask fix

* feat: render state instead of internal

* feat: add __tres local state to nodeOps instances

* feat: add context to root on instances localstate

* feat: camera registration ops from node local state ctx

* feat: event handling registration from localState of nodes

* feature: disposable flag on node localstate

* feat: remove userData from types

* chore: remove unused import

* fix(test): fake localstate `.__tres` on tests

* fix(types): fix nodeOps instances localstate type
* Update orthographic camera aspect when screen size updates
* Give user a "manual" flag to keep Tres from updating camera
* feat(nodeOps): switch instance logic for reactive `object` prop

* chore: playground primitives with models

* chore: fix linter

* chore: fix tests and linters, primitive object is now reactive

* chore: refactor instance swaping logic to overwrite set and copy properties

* chore: tests

* chore: remove console.log

* chore: remove unused import watch

* feat: add primitive conditional to patch object prop
* fix: `nodeOps` is now a function

* chore(test): updated tests for `nodeOps`
@alvarosabu
Copy link
Member Author

alvarosabu commented Mar 20, 2024

@andretchen0 is this what you mean? I'm struggling to fix the tests, I guess we need to export the weakmap to use it there, how would that work, I also understand that the weakMap is aimed for privacy.

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 4d7cc05
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/65faba5bcffc41000722cc32
😎 Deploy Preview https://deploy-preview-593--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit b023312
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/65fabaa0a7e7890008d8b459
😎 Deploy Preview https://deploy-preview-593--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alvarosabu alvarosabu changed the base branch from main to v4 March 30, 2024 15:26
@alvarosabu alvarosabu added the p1-chore Doesn't change end-user code behavior (priority) label Mar 30, 2024
Base automatically changed from v4 to main May 30, 2024 06:32
@alvarosabu alvarosabu closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change end-user code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move TresObject.__tres to a WeakMap
2 participants