Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Dialog title is too long #737

Open
Enes5519 opened this issue Nov 1, 2023 · 2 comments
Open

[Feature Request]: Dialog title is too long #737

Enes5519 opened this issue Nov 1, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@Enes5519
Copy link
Contributor

Enes5519 commented Nov 1, 2023

Describe the problem or use case

The Dialog caption is currently nowrap, but this can be ugly in some cases and it may be necessary to increase it to 2 lines.

Actual
image

Expected
image

Proposed solution

We can add a line clamp and keep its value in a css variable.

https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-line-clamp

Alternatives considered

We can add the ability to adjust the dialog width. We can also remove Nowrap from the caption.

Additional technical context

No response

@leventozen leventozen added the good first issue Good for newcomers label Nov 7, 2023
@umutbozdag
Copy link

umutbozdag commented Nov 15, 2023

Hi @Enes5519, I would like to work on this but when I start storybook server, I can't see any components related to Baklava. These are the errors I get:
image

Do you have an idea how can I fix this?

@leventozen
Copy link
Member

Hey @umutbozdag, I couldn't reproduce your issue in my local environment. Can you give us more details about how to run the application, your npm and node version's and your browser and browser version etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants