Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for quick primitive creation like cylinders #398

Open
WarrenMarshall opened this issue Mar 2, 2013 · 17 comments · May be fixed by #4399
Open

Support for quick primitive creation like cylinders #398

WarrenMarshall opened this issue Mar 2, 2013 · 17 comments · May be fixed by #4399
Assignees
Labels
Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working Type:Enhancement New features

Comments

@WarrenMarshall
Copy link

No description provided.

@kduske
Copy link
Collaborator

kduske commented Mar 2, 2013

I guess pipes would also be cool. What else?

@WarrenMarshall
Copy link
Author

Well, it's mainly cylinders for me since you do that a lot for columns, curve templates, etc. A spike (cone) would be handy too as Quake tends to use those a lot thematically...

@SpiritQuaddicted
Copy link

I would suggest going straight ahead into making this a full prefab system. Have a directory with tailored .map files that can be easily added. Then you can ship with such primitives and let the mappers add their own similar (or more complex) shapes.

I either suggested that before or Warren's editor has it or it was in another editor or it was suggested by someone else before, I am not sure. ;)

@kduske
Copy link
Collaborator

kduske commented Mar 2, 2013

I used to have this in the Mac version, but it wasn't so useful. I think it may be more interesting to build such shapes on the fly and to let users change parameters such as number of edges etc.

@WarrenMarshall
Copy link
Author

Or support OBJ importing! :) Let me make my own convex shapes in other apps and just import them as I need them.

@ryanbriscall
Copy link

Yes, we need this. I always created circle brushes. Please see how I create circle brushes in Quest editor: http://www.youtube.com/watch?feature=player_detailpage&v=MpGsBb6EPZQ#t=195s

Oh, just to comment on Warren's request for OBJ import. You could import OBJ into one editor, then save as .map and then open that .map in TrenchBroom and copy the brushes, then open your map and paste.

@adryft
Copy link

adryft commented May 10, 2016

Sorry to nag but it's been over 3 years, is this and the prefab system any further along?
It's an incredibly basic feature for an editor like this and furthermore switching back & forth between applications, importing/exporting etc etc to create primitives is beyond silly.

Suggestions:

  • Block (already available)
  • Cylinder (option to change the # of faces)
  • Sphere (option to change the # of faces)
  • Arch (would require some kind of menu)
  • Spike/Cone (option to change the # of faces)

"Rock" would be a nice extra (it's available in JackHammer)
A randomly shaped block with a configurable # of faces that looks like (you've guessed it) a Rock.
Far more useful than it sounds and a serious timesaver when creating scenery/detail.

Thank you for your work on this project

@LordGrievous
Copy link

LordGrievous commented Oct 1, 2017

Instead of double posting I'll just post here :)

Kristian, are you still planning on implementing this feature?
I don't think you should have a large set of primitives like most 3D programs. But the option to create cylinders would definitively go a long way to adding more options. Cones and spheres would also be particularly helpful, those are probably the most used primitives used anyway.

Edit, oh and arch too 👍

arch

@kduske kduske added Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Ready and removed Platform:All labels Feb 17, 2018
@ericwa ericwa self-assigned this Oct 20, 2018
@kduske kduske added Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working and removed Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. labels Mar 23, 2019
@MarkWilds
Copy link

@ericwa are you still working on this? I made this feature once in my own editor.
Based on the AABB that was used to draw the shape and a transformation matrix for the orientation.

I guess this is what is meant with this issue?
image

@LordGrievous
Copy link

Maybe include other parametric brushes like stairs?

Would be very helpful if these could be created on the fly with the possibility of editing the parameters (like number and width of stairs) as long as the shape isn't confirmed.

@ryanbriscall
Copy link

ryanbriscall commented Aug 9, 2020

Hey guys, I'm back. I spoke with ericw, and I requested that we go ahead and do something. Just start simple, then improve in later versions of TrenchBroom.

So, I mentioned my earlier comment (here) about simply doing:
Brush -> Create -> Prism. Enter radius. Enter # of sides. Press Return.

New video: https://youtu.be/4dgC_GeKWrs

ericw and I both realized that the practice of waiting for the "perfect" solution isn't always a good practice, and it's essentially held us back from having this powerful feature; to create circle brushes, quickly, easily, and accurately.

With the generated brush, a lot can be achieved, as you may already know from other youtube videos. I often use it as a template to draw stairs within it, or trim around it, or cut it into a half-circle and use it for archs or arch windows, and so on.

So, ericw says something like:

  • menu with Edit -> Create Brush -> Prism... ?
  • dialog box prompts for # of sides, radius, and height
  • create the brush in the center of the active viewport

@rtxa
Copy link

rtxa commented Aug 26, 2020

@ryanbriscall That's a good idea and easy to implement and mantain, when would you start with this?

@LordGrievous
Copy link

Has any of the volunteers made any progress on this feature?

@kduske
Copy link
Collaborator

kduske commented Aug 7, 2022

You keep asking about progress without ever getting any answers. Please stop it, it's just more noise in my inbox. Thank you.

@jitspoe
Copy link
Contributor

jitspoe commented Apr 8, 2023

Finally got TB compiling and started on something. No promises with the available time I have, but it's promising...
image

@jitspoe
Copy link
Contributor

jitspoe commented Jun 28, 2023

Never used Qt before, so it took way longer than I anticipated, and I've only gotten the cylinder in so far. 😅

trenchbroom_primitive

I've got a couple versions of the tool. One is in the toolbar like the other tool modes and lets you create a new cylinder by clicking and dragging.

The other lets you convert existing brushes into cylinders, allowing you to use the brush bounds or you can be more exact by specifying the dimensions (useful for big and/or precise stuff that's hard to drag out).

trenchbroom_primitive2

@jitspoe
Copy link
Contributor

jitspoe commented Jun 30, 2023

If anybody wants to give this a try, I have a test version compiled here: https://digitalpaint.org/temp/TrenchbroomWithCylinderSupportPass1.zip

Currently discussing best workflow and such in the PR: #4277, so feedback is appreciated! I want to have a lot more functionality (different shapes like cone, sphere, etc. as well as hollow options for making pipes, etc. and maybe more advanced stuff like arches).

@kduske kduske linked a pull request Dec 7, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working Type:Enhancement New features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants