Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking timestamps for stopovers #2535

Open
MrKrisKrisu opened this issue Apr 29, 2024 · 0 comments
Open

Checking timestamps for stopovers #2535

MrKrisKrisu opened this issue Apr 29, 2024 · 0 comments
Labels
bug Something isn't working Ringlines

Comments

@MrKrisKrisu
Copy link
Member

MrKrisKrisu commented Apr 29, 2024

Here's a reminder that the removal of the check for departure time equality caused new issues on trips that contain the the same stopover multiple times, as I mentioned in #2407 (comment) using my wrong account. I won't repeat the description, furthermore I don't have the capacity to create a new issue or fix it myself. I just wanted to put this comment here as a reminder since I feel it might have been overseen, especially as github hides it behind a resolved review.

Originally posted by @d3d9 in #2407 (comment)


@d3d9 do you have some input here before we are merging this as you worked on this snipped before? Thank you for notifying me. I'm afraid I wasn't able to respond earlier.
I think the departure time check was there for a good reason. On my first attempt testing out the new code, I could notice how, also using the Gesundbrunnen example, with a train that is passing it the second time, I get shown the stopovers before the second Gesundbrunnen one. Checking in fails ("Departure time must be before arrival time"), but we should prevent the wrong stopovers being displayed.
Instead of removing the departure time check, it should be kept and fixed with respect to timezones.

Originally posted by @kevin-a-vt in #2407 (comment)

@MrKrisKrisu MrKrisKrisu added Ringlines bug Something isn't working labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ringlines
Projects
None yet
Development

No branches or pull requests

1 participant