Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: New terminusStopover in trains/trips is wrongly marked as cancelled #2076

Open
marhei opened this issue Oct 21, 2023 · 1 comment
Open
Assignees

Comments

@marhei
Copy link
Contributor

marhei commented Oct 21, 2023

When a train has a new terminus, this stopover is also incorrectly marked as cancelled: true, because in HAFAS the departure (but not the arrival) was marked as cancelled.

Expected behaviour: The parameter cancelled should only be true if both arrival and departure have been cancelled.

Example train today: ICE 316 with new final stop Aachen Hbf, which is returned as cancelled according to API.

image
image

@HerrLevin
Copy link
Member

Little bit late to the party, but this is what we're getting from the HAFAS API. I'll look into it, wether we can make the cancellation consistent and a bit more... logical.

@HerrLevin HerrLevin self-assigned this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants