Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print shortcut should show print help message #132

Closed
simboonlong opened this issue Apr 21, 2020 · 0 comments
Closed

print shortcut should show print help message #132

simboonlong opened this issue Apr 21, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@simboonlong
Copy link
Contributor

Issue background

The print shortcut (cmd + p) should show help message, same as opencerts approach.

Screenshot 2020-04-21 at 2 04 32 PM

Proposed progressive solution

Maybe can do a iframe src url check to determine if renderer is not under same domain name, then show the print help message. Otherwise show up preview as it is:

Screenshot 2020-04-21 at 2 08 39 PM
@simboonlong simboonlong added the enhancement New feature or request label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simboonlong @tradetrustimda