You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@zippy1981 I was able to finally figure out how to revert the pull request :) .
The latest code (after adding DBConnector class and using it in the project), is available under commit# 3ecf13b. I have tested it a little against a standalone 2014 installation and I was able to get it to work.
Could you please take a look at let me know if everything looks 👍
I have submitted the same comments in the pull request but, remembered that a new issue is much better to provide feedback.
The text was updated successfully, but these errors were encountered:
OK I will try to review tomorrow. My first comment is the logging should be
replaced with something like log 4net and probably configured to go top the
event log. There will likely not be a lot of sql errors since only a small
number of DMV queries will happen in this app
On Oct 4, 2014 3:14 PM, "sqlchow" notifications@github.com wrote:
The latest code (after adding DBConnector class and using it in the
project), is available under commit# 3ecf13b 3ecf13b.
I have tested it a little against a standalone 2014 installation and I was
able to get it to work.
Could you please take a look at let me know if everything looks [image:
👍]
I have submitted the same comments in the pull request but, remembered
that a new issue is much better to provide feedback.
—
Reply to this email directly or view it on GitHub #8.
@zippy1981 I was able to finally figure out how to revert the pull request :) .
The latest code (after adding DBConnector class and using it in the project), is available under commit# 3ecf13b. I have tested it a little against a standalone 2014 installation and I was able to get it to work.
Could you please take a look at let me know if everything looks 👍
I have submitted the same comments in the pull request but, remembered that a new issue is much better to provide feedback.
The text was updated successfully, but these errors were encountered: