Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook support get request method #14

Open
jarvis2f opened this issue Mar 27, 2024 · 2 comments
Open

Webhook support get request method #14

jarvis2f opened this issue Mar 27, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jarvis2f
Copy link

Hello, this is a great project, but I found some possible issues while using it today.
I saw that the configuration of the webhook supports get requests, but the request failed.

Maybe it's a problem here:

@app.post("/webhook/{path}/{secret}")

And maybe the content-type can be arbitrary and the payload can be empty?

@daryllimyt
Copy link
Contributor

Hey! Thanks for raising this - we are aware the UI suggests that we currently support both POST and GET, but atm we only support POST. We definitely want to add support for GETs for webhooks soon though.

@topher-lo topher-lo added the enhancement New feature or request label Apr 3, 2024
@topher-lo topher-lo self-assigned this May 17, 2024
@topher-lo
Copy link
Contributor

I'll take this on for the v0.0.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants