Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the BackendService Plugin by an injected method #565

Open
rhuille opened this issue Jul 3, 2020 · 0 comments
Open

Replace the BackendService Plugin by an injected method #565

rhuille opened this issue Jul 3, 2020 · 0 comments
Labels
tech technical tasks

Comments

@rhuille
Copy link
Contributor

rhuille commented Jul 3, 2020

I / Remove fetchCollections method

BackendService has 2 methods:

  • executePipeline
  • fetchCollections

Only executePipeline is useful, fetchCollections should be removed

|| / Replace the store.subscribe by a store.watch on registerModule

https://github.com/ToucanToco/weaverbird/blob/master/src/store/backend-plugin.ts#L110

III / Inject the executePipeline as an action store

[WIP]

Technically, how should we do that ?

@rhuille rhuille added ui tech technical tasks and removed ui labels Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech technical tasks
Projects
None yet
Development

No branches or pull requests

1 participant