Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert the condition when filtering on unique values #543

Open
adimascio opened this issue May 14, 2020 · 1 comment
Open

Invert the condition when filtering on unique values #543

adimascio opened this issue May 14, 2020 · 1 comment
Labels

Comments

@adimascio
Copy link
Contributor

If I have 3 unique values "A", "B" and "C" in my column and I unclick on "A" and "B" to keep only "C", I expect the filter condition being generated to be value equal C rather than value not in (A, B)

@adimascio adimascio added the ui label May 14, 2020
@davinov
Copy link
Member

davinov commented May 25, 2020

Are you sure this is what we want ?
Imagine a collection with a great number of unique values. When I uncheck one of these values, I would expect the app to understand "I want to exclude this values from the result", and not "hardcode" all the other values as included.
This seems typically userful for null, 0, N/A or "Total" exclusion, when the other values are all relevant.

Moreover, in your example, there is a way to generate "value equal C" and not value "value not in (A, B)". The way is to hit "uncheck all" and then check C. If we remove that possibility, there will be no way left to generate not in conditions from the filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants