Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output column names consistent #460

Open
adimascio opened this issue Mar 2, 2020 · 3 comments
Open

Make output column names consistent #460

adimascio opened this issue Mar 2, 2020 · 3 comments
Labels
tech technical tasks

Comments

@adimascio
Copy link
Contributor

In src/lib/steps.ts, we define the output column name with at least 4 different names:

  • newcolumn
  • `new_column,
  • new_column_name,
  • newColumName

Let's pick a single one :).

@adimascio adimascio changed the title Make output column names uniform Make output column names consistent Mar 2, 2020
@adimascio
Copy link
Contributor Author

Here are my personal choices in decreasing order of preference:

  • newcolumn
  • new_column
  • new_column_name (but please don't choose this one)

The last one simply burns my eyes :)

@adimascio adimascio added the tech technical tasks label Mar 2, 2020
@davinov
Copy link
Member

davinov commented Mar 2, 2020

As this is supposed to live in a js object and then stored as JSON, I recommend following the well-established convention of camelCase.

In Google JSON style guide:

Property names must be camel-cased, ascii strings.
https://google.github.io/styleguide/jsoncstyleguide.xml?showone=Property_Name_Format#Property_Name_Format

Therefore, I suggest simply newColumn.

@vdestraitt
Copy link
Contributor

+1 for newColum. We have to think about changing the related doc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech technical tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants