Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaAvro Sink/Source don't reset version after topic chagned #2279

Open
lciolecki opened this issue Sep 28, 2021 · 1 comment
Open

KafkaAvro Sink/Source don't reset version after topic chagned #2279

lciolecki opened this issue Sep 28, 2021 · 1 comment
Labels
enhancement not on roadmap Nussknacker development team does not plan to work on that in foreseeable future

Comments

@lciolecki
Copy link
Contributor

When I chose topic and version and after that I change topic then version doesn't rest to default version. So there can be situation when we set first topic version which doesn't existed in second topic and after that nk show us information about not existed version..

@lciolecki lciolecki added the bug label Sep 28, 2021
@arkadius
Copy link
Member

arkadius commented Oct 5, 2021

Currently our dynamic node validation mechanism override parameter values provided by the user only if they are not defined. To make described feature available we should change a few things:

  1. dynamic node validation should be aware of which values were changed (currently it takes only snapshot of values, without knowledge what was before the change)
  2. developer of component should consider this information in their GenericNodeTransformation.contextTransformation logic and return not only parameters definition, but also information about which parameter values should be reset to default value

@arkadius arkadius added enhancement not on roadmap Nussknacker development team does not plan to work on that in foreseeable future and removed bug labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement not on roadmap Nussknacker development team does not plan to work on that in foreseeable future
Projects
None yet
Development

No branches or pull requests

2 participants