Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling validators - added checks to avoid not intended usage #1339

Open
mproch opened this issue Nov 30, 2020 · 1 comment
Open
Labels

Comments

@mproch
Copy link
Collaborator

mproch commented Nov 30, 2020

e.g.
'' + 'dd'
is considered blank....

@mproch mproch added the bug label Nov 30, 2020
@arkadius
Copy link
Member

In fact, this validator like others e.g. min/max and so on for now only works with literal expressions (eager parameters) and IMO there is no need to make it work with lazy parameters. Work that should be done is:

  • Add documentation - maybe here: https://nussknacker.io/API.html ?
  • Add check that validation annotation is not added to lazy parameters - maybe also check that you've added editor that validator is intented to work with

@arkadius arkadius changed the title Not blank validator is too restrictive Better handling validators - added checks to avoid not intended usage Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants