Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New data-source name accepts "<,>" but shows html entities "&lt;" and "&gt;" accordingly. #4577

Closed
withshubh opened this issue Oct 23, 2022 · 8 comments
Closed

New data-source name accepts "<,>" but shows html entities "&lt;" and "&gt;" accordingly. #4577

withshubh opened this issue Oct 23, 2022 · 8 comments
Assignees
@rudeUltra
Labels
bug Something isn't working platform roadmap tested
Milestone
Platform 17.2

Comments

@withshubh
Copy link
Contributor

Is your proposal related to a problem?

Creating a new datasource with a name that includes <,> shows HTML entities instead of the actual characters.

Describe the solution you'd like

Fix the issue so the new datasource displays the name as it is entered rather than displaying HTML (&lt;)

Steps to reproduce the issue

  • Create/Open an app in ToolJet
  • Add a datasource
  • Edit the name of the datasource that includes < or >

Screenshot 2022-10-21 at 12 01 24 PM
@SarthakD15
Copy link

I want to work on this issue. Please assign it to me.

@SarthakD15
Copy link

@withshubh

@alammoiz
Copy link
Contributor

Could you please assign it to me?

@withshubh
Copy link
Contributor Author

Hey @SarthakD15

Thanks for showing interest in contributing to ToolJet. We've assigned the issue to you.

If you have any questions related to setting up ToolJet, feel free to join our Slack community here: Slack community

@SarthakD15 SarthakD15 removed their assignment Oct 25, 2022
@vedant-z
Copy link
Contributor

@withshubh May I work on this?

@withshubh
Copy link
Contributor Author

Sure @vedant-z - Assigned it to you.

@vedant-z
Copy link
Contributor

vedant-z commented Oct 27, 2022 •
edited

Hi @withshubh

If I am not wrong I need to make some changes in frontend/src/Editor/DataSourceManager/DataSourceManager.jsx

Specifically in createDatasource function

Am I going in right direction?

IMG_20221027_084526.jpg

Also is this the correct way to approach it or should I think of some other way?
https://stackoverflow.com/a/5796744

@withshubh
Copy link
Contributor Author

Hey @vedant-z - Are you still working on this issue?

@shubh22 shubh22 removed the javascript label Mar 3, 2023
@shubh22 shubh22 added roadmap and removed good first issue Good for newcomers up-for-grabs labels Mar 3, 2023
@shubh22 shubh22 added roadmap and removed roadmap labels Apr 5, 2023
This was referenced Apr 26, 2024
Closed
Merged
@shah21 shah21 mentioned this issue May 1, 2024
Merged
@ajith-k-v ajith-k-v added this to the Platform 17.2 milestone May 8, 2024
@rudeUltra rudeUltra mentioned this issue May 14, 2024
Merged
@shah21 shah21 mentioned this issue May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rudeUltra rudeUltra

Labels
bug Something isn't working platform roadmap tested
Projects
None yet
Milestone
Platform 17.2
Development

Successfully merging a pull request may close this issue.

Added decode entity function ToolJet/ToolJet
9 participants
@shubh22 @gsmithun4 @ajith-k-v @alammoiz @withshubh @SarthakD15 @vedant-z @rudeUltra @dishag18