Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowColumnReordering: true does not work while allowRowReordering: false #514

Open
HitomiTenshi opened this issue Jun 28, 2022 · 2 comments
Open

allowColumnReordering: true does not work while allowRowReordering: false #514

HitomiTenshi opened this issue Jun 28, 2022 · 2 comments

Comments

@HitomiTenshi
Copy link
Contributor

Expected behavior and actual behavior.

It is not possible to reorder columns when allowRowReordering is false.

Steps to reproduce the problem.

  1. Set allowColumnReordering to true
  2. Set allowRowReordering to false

Specifications like the version of the project, operating system, or hardware.

  • canvas-datagrid v0.4.5
  • Chrome latest
  • Windows 10
@HitomiTenshi HitomiTenshi changed the title allowColumnReordering: true does not work while allowRowReordering: flase allowColumnReordering: true does not work while allowRowReordering: false Jun 28, 2022
@HitomiTenshi HitomiTenshi mentioned this issue Jun 28, 2022
Merged
@Gagogaa Gagogaa mentioned this issue Jul 15, 2022
Open
@HitomiTenshi
Copy link
Contributor Author

Fixed in #515

@ndrsn
Copy link
Collaborator

ndrsn commented Apr 3, 2023

Apologies, I had to revert the PR as it was causing a bug / failing test when attempting to sort the column (by clicking on the column header). I'm going to spend some time in the near future getting the test suite modernized and easier to maintain, so I can figure out what's going, and we can fix this issue for good.

@ndrsn ndrsn reopened this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndrsn @HitomiTenshi