Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.2.0 #810

Closed
iphydf opened this issue Feb 23, 2018 · 10 comments
Closed

Release 0.2.0 #810

iphydf opened this issue Feb 23, 2018 · 10 comments
Assignees
Labels
P3 Low priority
Milestone

Comments

@iphydf
Copy link
Member

iphydf commented Feb 23, 2018

I suggest we release 0.2.0 without #295. We have the API addition required in master now, and in order not to break the API when we do push #295, we'll need to write some additional code that takes care of figuring out joins/leaves the best we can.

The persistent group chats haven't seen much testing yet, and it would be sad if 0.2.0 were a broken release. This means more work for us, but it allows us to release the (already way too large and overdue) next version sooner and takes pressure off client developers to adopt the change right now.

@iphydf iphydf added this to the v0.2.0 milestone Feb 23, 2018
@iphydf
Copy link
Member Author

iphydf commented Feb 23, 2018

@robinlinden
Copy link
Member

I think releasing now would be a good idea. I've opened a PR updating the CHANGELOG.md and can tag a release whenever this weekend.

@tox-user
Copy link
Member

tox-user commented Feb 23, 2018

@sudden6 fixed the crashes caused by persistent groups in qTox. It can be now tested with this PR: qTox/qTox#4964. There are a few small issues left to fix, but I think we are making a good progress. Once they are fixed, it would be good to test it with more people.

@sudden6
Copy link

sudden6 commented Feb 23, 2018

I don't support this. The persistent conferences are the most notable addition from the user perspective since a very long time and it would be a shame to postpone that indefinitely again.

I think we should merge #295 before tagging 0.2.0. There are several reason why:

  • The API is done and unlikely to change in a breaking way
  • The functionality seems to be working as intended, intensive testing and bug fixing can happen after 0.2.0 too.
  • we can gather experience until the next breaking change
  • clients can start to roll out testing versions and help uncover bugs that can only be seen "in the wild"

qTox is already on the way to support conferences, see the PR linked by @tox-user and it doesn't cause any major problems. I think other clients can support it in near time too.

@zoff99
Copy link

zoff99 commented Feb 24, 2018

@sudden6 its difficult. i would like to see persistent groups released soon. yet i also finally want the video fix to be in clients. that one has issues open for more than 2 years (even in irungentoos repo).
but you are right usually thing get postponed almost indefinitely.

i still lean towards releasing now. and following up with 0.2.1 in the next weeks (which should include persistent groups)

@SkyzohKey
Copy link

@sudden6 I finally agree with you. Didn't thinked this way and I guess you are right.

@iphydf
Copy link
Member Author

iphydf commented Feb 27, 2018

@sudden6 I've removed the old callback, so we can release 0.2.0 now, and put persistent conferences into 0.2.1 shortly after.

@sudden6
Copy link

sudden6 commented Feb 27, 2018

seems like a good compromise

@iphydf
Copy link
Member Author

iphydf commented Feb 28, 2018

@robinlinden I've merged the changelog update. Can you tag the release and add the changelog there?

@robinlinden
Copy link
Member

@iphydf iphydf added the P3 Low priority label Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low priority
Projects
None yet
Development

No branches or pull requests

6 participants