-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate that group chat peer's username is not known #768
Comments
What about using an empty string instead of using |
maybe somewhere along this line:
|
There has to be some default name. We could set it to an empty string and let clients decide what the default name should be, but then it will be different in each client. There is also another problem. Why is the string "Tox User" returned for every peer that joins and changed to user's real name later? It must mean that every joining user's name is empty at first. Why? |
I think letting the client decide the default name wouldn't be to bad, qTox already has a default name when you create a profile, wouldn't be much work to make one for groups.
Maybe the packet indicating the peer name arrives after the one indicating someone joined the group? Not sure what the protocol says here. |
In group chat when a joining peer's username is not known a string "Tox User" is returned. As far as I know toxcore gives no other indication about this. That means clients can never trust if the peer's name they got from toxcore is correct or not. "Tox User" can be a legitimate username, so there is no way to distinguish if it's a correct name. This makes creating join notifications for group chats difficult.
When a user joins a group chat we are in, we will at first see their name as "Tox User". Then it will probably get changed to their real name calling TOX_CONFERENCE_STATE_CHANGE_PEER_NAME_CHANGE. I don't know how clients get around it, but this should be changed.
in group.c:
The text was updated successfully, but these errors were encountered: