Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Discrepancy #90

Open
jeremy-rifkin opened this issue Dec 3, 2020 · 4 comments
Open

Color Discrepancy #90

jeremy-rifkin opened this issue Dec 3, 2020 · 4 comments

Comments

@jeremy-rifkin
Copy link

Hello,
I'm encountering a strange bug: the color picker tool is telling me that a color in an image is rgb (84, 85, 110), however, the photoshop eyedropper is telling me that the same color is rgb (84, 85, 108). Small difference, however, it's important for my use case.

The image is a png so I do not expect lossy compression to be a factor (although that shouldn't matter since the display color is what's being sampled). I do not believe the problem is related to the image viewing software I'm using as I've tested this in both photoshop and windows photos. I am also getting the issue with another color picker utility: Pipette.

This is a really weird bug and the issue very well may be on my end - either hardware or software. I am interested to know if anyone else has encountered a similar issue / knows the cause.

image

@Toinane
Copy link
Owner

Toinane commented Dec 3, 2020

Hey @jeremy-rifkin thank you for your issue! Yes its a know bug. Its due to the use of an external C++ module. It use a forced color space RGB that can be different of the color space used from your computer/monitor. Actually I can't do anything but use another C++ module or make my own (but I don't have the right knowledge for now)

@Toinane
Copy link
Owner

Toinane commented Dec 3, 2020

Actually Photoshop is also a problem, it use a particular color space, and I need to use the same color space to ensure to have the same RGB code from Photoshop. :/

@jeremy-rifkin
Copy link
Author

@Toinane Thanks for the quick reply! Good to know the cause of the issue.
I just tested two images, one RGB 8bit and one RGB 16bit. I am seeing the discrepancy only on the RGB 16bit image, which I think verifies that the problem is forced RGB color space.
I would be interested in contributing to a C++ module that could resolve this issue, if possible.

@Toinane
Copy link
Owner

Toinane commented Dec 3, 2020

Oh okey, its good to know yeah!
It would be amazing!! You can see my first attempt here: https://github.com/Toinane/native-picker
It's based on https://github.com/mockingbot/mb_colorpicker_desktop_native
But I want to use the N-api to make this C++ module more modulable with options like the grid size, show the previous colorpicker's color and others..

@Toinane Toinane added this to TO DO in Colorpicker 3.0.0 via automation Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants