We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removeOverrides()
As @dchakarov pointed out, removeOverrides evicts the entire cache but it could just remove the values that have been overridden.
removeOverrides
I think this should be a simple fix.
From:
public func removeOverrides() -> Set<Variable> { queue.sync(flags: .barrier) { defer { cache.evict() } ...
to:
public func removeOverrides() -> Set<Variable> { queue.sync(flags: .barrier) { guard let mutableValueProvider = mutableValueProvider else { return [] } let variables = mutableValueProvider.variables for variable in variables { cache.removeValue(forKey: variable) DispatchQueue.main.async { self.subjectsRefs[variable]?.send(completion: .finished) self.subjectsRefs[variable] = nil } } ...
The text was updated successfully, but these errors were encountered:
ashalva
No branches or pull requests
As @dchakarov pointed out,
removeOverrides
evicts the entire cache but it could just remove the values that have been overridden.I think this should be a simple fix.
From:
to:
The text was updated successfully, but these errors were encountered: