-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vectorized on Python 3.8 #810
Comments
@mikedh are you trying to pip install shapely into a conda environment? I see a hint of that at https://travis-ci.org/mikedh/trimesh/jobs/627984786#L1048. While this may work for pure-python packages, it cannot work for packages that include extension modules as shapely does. You simply cannot pip install the shapely wheels on PyPI into a conda environment, you must get shapely from a conda channel like conda-forge. |
Yeah,
Fails with:
|
Did a little debugging and tried a few things, none of which worked. For reference here is a slightly more useful Dockerfile:
And the full output of the shapely build steps:
|
@mikedh thank you for being patient and persistent. I've found the problem. The Shapely 1.6.4.post2 source distribution (sdist) is defective and does not include a _vectorized.c file.
The shapely 1.7a2 sdist does.
Would you be willing to try the 1.7a2 pre-release? It's in good shape, in my opinion. It has far fewer known bugs than 1.6.4.post2, and seems to be serving geopandas users quite well. If not, you might try python 3.7, we have binary wheels on PyPI for py37 and shapely 1.6.4.post2. |
Thanks for tracking this down! Yup looks like 1.7a2 does the trick. Kinda weird that it was reproducible even when building from a clone of the repo, maybe it was missing the geos headers or something? Feel free to close, or we can wait for the release to close. For other people who want the pre-release you can install it with: |
Trimesh user here, this thread saved my day. Props to the contributors for the 1.7.0 release including the fix! |
It looks like
from shapely import vectorized
fails on Python 3.8 when Shapely is installed via pip:https://travis-ci.org/mikedh/trimesh/jobs/627984786#L1423-L1426
I saw some "in the wild" reports of this too, though not sure what Python they were on:
mikedh/trimesh#667
The text was updated successfully, but these errors were encountered: