Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable runs and audit slack notifications #2061

Open
arabinelli opened this issue Jan 31, 2024 · 0 comments
Open

Enable runs and audit slack notifications #2061

arabinelli opened this issue Jan 31, 2024 · 0 comments
Labels
Improvement Improves existing functionality Scheduler: Airflow

Comments

@arabinelli
Copy link

As discussed with @izeigerman via Slack, currently Slack notifications only support plans, but not runs and possibly audits. It would be good to be able to receive notifications for those events as well.

In addition, as a feature suggestion, it might be desirable in future releases to filter the notification target by model tags in order to reduce alerting fatigue for larger teams.

E.g. I imagine being able to configure something like

notification_targets=[
    # plans are sent to a specific channels regardless of tags
    SlackApiNotificationTarget(
        notify_on=PLAN_EVENTS,
        token=os.getenv("SLACK_API_TOKEN"),
        channel="UXXXXXXXXX",  # Channel ID of #data-sqlmesh-deploys-prd
    ),
   # runs and audit failures for the marketing team's models
    SlackApiNotificationTarget(
        notify_on=RUN_AND_AUDIT_FAIL_EVENTS,
        token=os.getenv("SLACK_API_TOKEN"),
        channel="UXXXXXXXXX",  # Channel ID of #data-marketing-alerts-prd
        include_tags=["team:marketing"]
    ),
   # runs and audit failures for the data platform team's models
    SlackApiNotificationTarget(
        notify_on=RUN_AND_AUDIT_FAIL_EVENTS,
        token=os.getenv("SLACK_API_TOKEN"),
        channel="UXXXXXXXXX",  # Channel ID of #data-platform-alerts-prd
        include_tags=["team:data_platform"]
    )
]

Where team:data_platform and team:marketing are tags applied in the models DDL

@treysp treysp added the Improvement Improves existing functionality label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improves existing functionality Scheduler: Airflow
Projects
None yet
Development

No branches or pull requests

3 participants