Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question - can i fix the height and width of the required image to 130 x 600? #68

Open
tiviti opened this issue Feb 26, 2016 · 8 comments

Comments

@tiviti
Copy link

tiviti commented Feb 26, 2016

Hardware

Expected Behavior

Actual Behavior

Steps to Reproduce

@TimOliver
Copy link
Owner

Answer - Not inside this controller.

Are you asking that the image itself needs to be 130x600 before it's passed to the controller? If so, that might be better off as logic performed inside your app beforehand. :)

@tiviti
Copy link
Author

tiviti commented Feb 27, 2016

Thanks Oliver. We want the output image to fixed at 600x130, hence we want
the user to be able to move the 600x130 rectangle over the image to crop it
accordinaly

On Sat, Feb 27, 2016 at 5:55 AM, Tim Oliver notifications@github.com
wrote:

Answer - Not inside this controller.

Are you asking that the image itself needs to be 130x600 before it's
passed to the controller? If so, that might be better off as logic
performed inside your app beforehand. :)


Reply to this email directly or view it on GitHub
#68 (comment)
.

Ilan Kasan

@TimOliver
Copy link
Owner

That's definitely not possible in the current version of this library. But it would be pretty easy to add. Feel free to submit a PR! :)

@emilypriddy
Copy link

I was wondering something along the same lines but it would limit the user to using only the square aspect ratio.

@pedro380085
Copy link

👍

@CWJie91
Copy link

CWJie91 commented Jan 31, 2018

Hi Oliver, is this feature implemented?
If yes, can you share the techical detail?
Thanks

@TimOliver
Copy link
Owner

TimOliver commented Feb 1, 2018

There seems to be some mass confusion in here. My name is Tim. Oliver is my surname. 🤣

Nope, this feature isn't implemented yet. I don't have time to add features that aren't involved with my own app's requirements. Sorry!

This one shouldn't be too hard to add if anyone else wants to file a PR. :)

@CWJie91
Copy link

CWJie91 commented Feb 6, 2018

Dear Tim,
Noted with thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants