Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OS Catalyst Support #395

Open
iDevid opened this issue Nov 29, 2019 · 12 comments
Open

Mac OS Catalyst Support #395

iDevid opened this issue Nov 29, 2019 · 12 comments

Comments

@iDevid
Copy link

iDevid commented Nov 29, 2019

Is your feature request related to a problem? Please describe.
This future request relates to Mac OS Catalyst introduction during this WWDC19.

Describe the solution you'd like
Fully support to Mac OS Catalyst

Describe alternatives you've considered

Additional context

@TimOliver
Copy link
Owner

What does it need to support Catalina exactly?

@itayAmza
Copy link

itayAmza commented Jan 2, 2020

Any news for this issue? is there a workaround for using this pod with Catalyst?

@TimOliver
Copy link
Owner

TimOliver commented Jan 2, 2020

Um, no? I still have no idea what is needed to support Catalyst.

Can someone please explain what’s going on?

I‘m sorry, but I’m future it looks like I need to be far more strict on issues that don’t follow the issue guidelines I request in submitting zero useable information.

@iDevid Please outline what the main issues are for supporting Catalyst within 24 hours, or I’m closing this issue.

@iDevid
Copy link
Author

iDevid commented Jan 2, 2020

Actually seems that the real problem is due to CocoaPods.
CocoaPods Issue

@TimOliver
Copy link
Owner

Ohhh. Wow! Okay, thanks for clarifying!

I'll take a look at it! Thanks for that! :)

@itayAmza
Copy link

itayAmza commented Jan 8, 2020

@TimOliver any new version expected soon?

@TimOliver
Copy link
Owner

@itayAmza Nope, no new versions at the moment. Sorry!

I don't have any need for Catalyst support for the time being in my current project so this is super low priority for me.

If you specifically need Catalyst support, you can consider filing a PR, but it looks like this is a CocoaPods-side issue for the time being, so there might not be anything we can do for now.

@TimOliver TimOliver removed their assignment Jan 8, 2020
@itayAmza
Copy link

Easy fix for now based on @chrisballinger response

post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            ##Fix TOCropViewController code sign issue for macCatalyst
            if target.name == "TOCropViewController-TOCropViewControllerBundle"
              puts "Adding #{target.name} development team"
              config.build_settings['DEVELOPMENT_TEAM'] = 'XXXXXX'
            end
        end
    end
end

@TimOliver
Copy link
Owner

Cool! Glad you were able to find a work-around that ended up working for you!

From the sound of it, there’s nothing I can do to fix this on my end except pray that Xcode 12 will fix it.

I’ll leave this issue open for now. I’ll add a notice in the README to explain this workaround and then close it.

@masaldana2
Copy link

That fix works for building it, but to submit to appstore i get the same error

@TimOliver
Copy link
Owner

I've been playing with a Mac Catalyst app and ran into the same issue with other libraries now. It seems any CocoaPods packages that contain any kind of resources (images, language strings etc) is having this problem.

HOPEFULLY Apple will have added ways to fix this in the next version of Xcode, but until then, we're kinda at the mercy of CocoaPods themselves to engineer a workaround.

@masaldana2
Copy link

masaldana2 commented May 30, 2020

I installed it manually, added the bridge header and the delivery to the appstore was successful for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants