Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small tweaks allows running on ATMega2560 #403

Open
ClutchplateDude opened this issue Apr 5, 2024 · 1 comment · May be fixed by #404
Open

Small tweaks allows running on ATMega2560 #403

ClutchplateDude opened this issue Apr 5, 2024 · 1 comment · May be fixed by #404

Comments

@ClutchplateDude
Copy link

Describe the bug
The library does not compile out of the box for an Arduino ATMega2560 board (or any other 8-bit board)

To Reproduce
Steps to reproduce the behavior:

  1. Open Sketch
  2. Set Board to and Arduino Mega2560
  3. Compile
  4. _frequency overflow

Expected behavior
Would be great to be able to use this library on a Arduino 8-bit board (almost there)

Versions (please complete the following information):

  • Library: 4.4.1
  • Platform: Arduino atmelavr@4.2.0

Additional context
If the type of the _frequency variable of the SSD1306Wire class is changed from int to long, it will work.
Also, using PlatformIO, I get compiler warnings about ctor parameters shadowing members. If you remove the leading underscores from the ctor parameters, it goes away.
@ClutchplateDude
Copy link
Author

I have tested this on our project that can be built for Mega2560 and ESP32 and the library works on both platforms with this tweak. I will open a PR for this shortly.

@ClutchplateDude ClutchplateDude linked a pull request Apr 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Mega2560 board (and other 8-bit boards) ClutchplateDude/esp8266-oled-ssd1306
1 participant
@ClutchplateDude