Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom DroneModels.json to be loaded at runtime #86

Open
mkrupczak3 opened this issue Jul 24, 2023 · 1 comment
Open

Allow custom DroneModels.json to be loaded at runtime #86

mkrupczak3 opened this issue Jul 24, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mkrupczak3
Copy link
Member

Description:

Currently, the DroneModels JSON file is hard-coded into the app and is not user-configurable. While it has data for many drone models, it is conceivable that users may find their particular drone is unsupported. In addition, some users of proprietary drones may not be permitted by their workplace to share details of their drone with this project.

The program should let a user load their own custom JSON file so that they can configure and add support for their own particular drone model

User Story

As a User, I want to load a DroneModels JSON file, so that I can use my drone with the app

@mkrupczak3
Copy link
Member Author

I'm kind of conflicted about whether to implement this feature.

On the one hand, it makes testing easier, allowing the user to tweak their camera parameter values to find the values with best accuracy.

A significant drawback however is that it may discourage users from contributing their values back to the DroneModels upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant