Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to convert any io.Reader (or maybe any image.Image) to aic_package #34

Open
different55 opened this issue Mar 13, 2023 · 1 comment

Comments

@different55
Copy link

different55 commented Mar 13, 2023

Having aic_package.Convert handle opening local files or fetching remote files seems like it should be out of scope for a function that's just named Convert. Having it (or another function) handle a generic io.Reader or image.Image would be hugely useful. Right now it's not really possible to use aic_package to ascii-fy an embedded or generated image, for example.

@TheZoraiz
Copy link
Owner

Yea, the current library support is just cli usage exposed as a package. It's definitely not as refined as it should be. I'll probably create another function that takes image.Image when I implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants