Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Ideas for Improving Office Data #12

Open
woodhull opened this issue Feb 17, 2017 · 2 comments
Open

Various Ideas for Improving Office Data #12

woodhull opened this issue Feb 17, 2017 · 2 comments

Comments

@woodhull
Copy link

Hello!

We've started ingesting the office data too and are thinking about ways to make the data work well going forward. We have some ideas that it would be good to get feedback on.

  • Adding office IDs. This would perhaps facilitate inter-app communication if anyone ever needs to link to info in another system about offices, and most importantly would facilitate easier data refreshes. Perhaps the ID could be derived from the data? bioguide-city-state plus an optional integer if there ends up being more than one office in a city (this happens in cities like New York) for eg?

  • Standardizing the addresses. We could either go for easy to read or USPS standardization, but it seems good to agree on a standard format. Right now there are inconsistencies in Suite abbreviation and a few other oddities.

Do you plan to submit a PR to the upstream united-states repo? It seems like more people would find this data and contribute fixes if it were included upstream. We stumbled across the fact that you were publishing this really randomly.

Anyways, thanks for doing this, and hopefully we can be helpful in keeping the data up to date going forward. Looking forward to collaborating with you.

cc @arrighik @anero @lavaturtle

@TheWalkers
Copy link
Owner

Thanks for the ideas, makes sense. Upstream is not interested in adding any additional data to their repo.

@tcarobruce
Copy link
Collaborator

Adding office IDs.
Merged pull request #13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants