New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting antenna gain doesnt take immediate affect #6979
Comments
This is actually by design. Gateway settings are stored in the Identity Server and gateways connect to the Gateway Server. These may be in different clusters and we use the gateway reconnection to sync settings. If you are using LBS, we need to report the antenna gain to the gateway during the connection. This means that the changes cannot reflect in the same connection. For UDP, I don't see a technical reason for waiting for a new connection other than the TTS architecture. What we can do is to trigger a server-side disconnect of the gateway if the antenna gain is adjusted? Then the gateway can reconnect and fetch new data. Would that be something that works for your requirement? |
Yes that sounds good, a server side forced reconnection should do the trick |
Ok thanks. Do @adriansmares or @johanstokking see a reason against triggering a gateway reconnection on antenna gain change? We have this mechanism already for changes in the location type. |
I don't see a reason against it - we probably should just update this check to also look at the antenna gain. lorawan-stack/pkg/gatewayserver/gatewayserver.go Lines 601 to 630 in ed1a5f8
|
Yes, sounds like a good reason to reconnect. |
Summary
When changing the antenna gain on a gateway it has no affect until a gateway disconnects. It takes a full disconnection timeout until messages start being scheduled with the new TX power
Steps to Reproduce
Current Result
Transmit power doesnt change until gateway disconnects
Expected Result
Gain takes affect immediately and transmit power changes
Relevant Logs
No response
URL
No response
Deployment
The Things Stack Open Source (self-hosted)
The Things Stack Version
3.28.0
Client Name and Version
No response
Other Information
No response
Proposed Fix
Compare changes to the antenna properties and require a gateway disconnect here
Contributing
Code of Conduct
The text was updated successfully, but these errors were encountered: