Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit Safari WebSocket compression behavior #6782

Open
4 tasks done
adriansmares opened this issue Dec 19, 2023 · 1 comment
Open
4 tasks done

Revisit Safari WebSocket compression behavior #6782

adriansmares opened this issue Dec 19, 2023 · 1 comment
Assignees
@adriansmares
Labels
c/console This is related to the Console goldplating This is just polishing
Milestone
Backlog

Comments

@adriansmares
Copy link
Contributor

Summary

Currently Safari versions 15, 16 and 17 cannot properly operate when WebSocket compression is enabled. As such, compression is disable in the Console internal WebSocket API completely for Safari user agents.

Current Situation

Compression is completely disabled for Safari. We should recheck periodically (quarterly ?) if this ever gets fixed in Safari.

Why do we need this? Who uses it, and when?

The bandwidth usage savings are non trivial when compression is enabled. At the same time, this problem exists since 2020, in many forms, so I am not particularly optimistic about a speedy fix.

Proposed Implementation

Once the fix becomes widely adopted on a market share basis, we can consider removing the Safari check completely.

Contributing

  • I can help by doing more research.
  • I can help by implementing the feature after the proposal above is approved.
  • I can help by testing the feature before it's released.

Code of Conduct
@adriansmares adriansmares added c/console This is related to the Console goldplating This is just polishing labels Dec 19, 2023
@adriansmares adriansmares self-assigned this Dec 19, 2023
@github-actions github-actions bot added the needs/triage We still need to triage this label Dec 19, 2023
@adriansmares adriansmares mentioned this issue Dec 19, 2023
Merged
6 tasks
@KrishnaIyer
Copy link
Member

Ok let's put it into the backlog and revisit it every 3 months to see if Safari support is added.

@KrishnaIyer KrishnaIyer added this to the Backlog milestone Dec 20, 2023
@KrishnaIyer KrishnaIyer removed the needs/triage We still need to triage this label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adriansmares adriansmares

Labels
c/console This is related to the Console goldplating This is just polishing
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@KrishnaIyer @adriansmares