Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New gateway registration flow (Console) #3947

Closed
kschiffer opened this issue Mar 18, 2021 · 9 comments
Closed

New gateway registration flow (Console) #3947

kschiffer opened this issue Mar 18, 2021 · 9 comments
Assignees
Labels
blocked This can't continue until another issue or pull request is done c/console This is related to the Console technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface

Comments

@kschiffer
Copy link
Member

Summary

Congruently to #3522, we also want to revisit the gateway registration flow, which is currently too verbose and has many options that are usually not relevant during registration. Additionally, we can use templates of the device repository once we add support for gateways.

Why do we need this?

Gateway onboarding is currently not smooth.

What is already there? What do you see now?

Gateway registration using the gateway registration form.

What is missing? What do you want to see?

How do you propose to implement this?

This issue is currently still a bit of a stub. I will follow up timely with wireframes to make this issue actionable. Implementation will likely happen in two stages:

  1. Clean up of the current onboarding without device repository
  2. Addition of onboarding via device repository to provide two onboarding modes, congruently with end device onboarding

How do you propose to test this?

While doing so, we should also extend the gateway end-to-end tests accordingly.

Can you do this yourself and submit a Pull Request?

I'll follow up with the wireframes and then we can decide who picks up the implementation.

@kschiffer kschiffer added c/console This is related to the Console technical debt Not necessarily broken, but could be done better/cleaner needs/ux This needs UX design / approval needs/triage We still need to triage this labels Mar 18, 2021
@kschiffer kschiffer self-assigned this Mar 18, 2021
@nejraselimovic nejraselimovic added this to the Next Up milestone Mar 23, 2021
@htdvisser htdvisser removed the needs/triage We still need to triage this label Mar 23, 2021
@kschiffer kschiffer modified the milestones: Next Up, 2021 Q2 Mar 23, 2021
@nejraselimovic nejraselimovic removed this from the 2021 Q2 milestone Mar 23, 2021
@kschiffer kschiffer added this to the 2021 Q2 milestone Mar 23, 2021
@kschiffer kschiffer modified the milestones: 2021 Q2, 2021 Q3 Jul 6, 2021
@kschiffer kschiffer added size/large Bigger than you think ui/web This is related to a web interface labels Jul 6, 2021
@johanstokking
Copy link
Member

  • Clean up of the current onboarding without device repository

Let's start with this indeed.

Do you need a list of fields that are advanced, with their default values? That would eliminate already some fields that are always shown now.

@johanstokking
Copy link
Member

Other things in scope:

@kschiffer kschiffer removed the needs/ux This needs UX design / approval label May 18, 2022
@johanstokking
Copy link
Member

Should we triage this then? @NicolasMrad

@NicolasMrad NicolasMrad added this to the v3.20.1 milestone May 23, 2022
@kschiffer kschiffer assigned mjamescompton and unassigned kschiffer May 27, 2022
@kschiffer kschiffer removed the size/large Bigger than you think label May 27, 2022
@kschiffer
Copy link
Member Author

kschiffer commented Jun 1, 2022

@mjamescompton

Here's the scaffold I would suggest for this:

image

Let me know if you have any questions. You can also refer to my comment on end device onboarding. Many notes are relevant for this as well.

Again, here's the full wireframe:
https://github.com/TheThingsNetwork/lorawan-stack/files/8715860/220517_integrated_gateway_onboarding_01.pdf

Note that there are two onboarding flows, based on whether the gateway is claimable or not (<GatewayRegistrationFormSection /> and <GatewayClaimFormSection />). Please make sure to resolve any unclarities about it before starting the implementation. Thanks!

@johanstokking
Copy link
Member

References also TheThingsNetwork/lorawan-devices#124.

If there's anything needed that is generic for a particular gateway and model, we might want to load that from the device repository too.

@mjamescompton mjamescompton added the in progress We're working on it label Jun 7, 2022
@NicolasMrad NicolasMrad modified the milestones: v3.20.1, v3.20.2 Jun 22, 2022
@NicolasMrad NicolasMrad modified the milestones: v3.20.2, v3.21.0 Jul 18, 2022
@NicolasMrad NicolasMrad modified the milestones: v3.21.0, v3.21.1 Aug 8, 2022
@kschiffer kschiffer mentioned this issue Aug 10, 2022
5 tasks
@kschiffer
Copy link
Member Author

The new gateway onboarding foundation (as laid out here: #3947 (comment)) was just merged and is now available in OS and Enterprise.

I'm leaving this issue open since there are still some missing bits:

@mjamescompton is currently working on updating the documentation accordingly.

@NicolasMrad NicolasMrad modified the milestones: v3.21.1, 2022 Q3 Aug 29, 2022
@NicolasMrad NicolasMrad modified the milestones: 2022 Q3, 2023 Q1 Oct 10, 2022
@NicolasMrad NicolasMrad modified the milestones: 2023 Q1, 2023 Q2 Apr 12, 2023
@KrishnaIyer
Copy link
Member

The two remaining items here depend on https://github.com/TheThingsIndustries/lorawan-stack/issues/2018. I'm removing the milestone on this until we resolve the blocker.

@KrishnaIyer KrishnaIyer added blocked This can't continue until another issue or pull request is done and removed in progress We're working on it labels Jul 4, 2023
@KrishnaIyer KrishnaIyer removed this from the 2023 Q2 milestone Jul 4, 2023
@kschiffer
Copy link
Member Author

I would even suggest to close this and track the rest of the progress in #2018 and a new issue once this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This can't continue until another issue or pull request is done c/console This is related to the Console technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface
Projects
None yet
Development

No branches or pull requests

7 participants